Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to ES Modules #69

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Convert to ES Modules #69

wants to merge 5 commits into from

Conversation

JuanM04
Copy link

@JuanM04 JuanM04 commented Oct 15, 2022

Closes #66

arg now exports a CJS and ESM version. For compatibility reasons, I've avoided using any export default, resulting in this breaking change:

const arg = require('arg')

// Before
const args = arg(/* ... */)

// After
const args = arg.run(/* ... */)

Note: that change can be avoided if the package goes ESM-only, but that seem too radical

@leerob let me now what you think about these changes

@JuanM04
Copy link
Author

JuanM04 commented Oct 18, 2022

I've added a pnpm build step in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert to ES Modules
1 participant
@JuanM04