Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOXELFORMAT: change the interface for the Format class to use Archives and not Streams #460

Closed
mgerhardy opened this issue May 6, 2024 · 0 comments · Fixed by #461
Closed

VOXELFORMAT: change the interface for the Format class to use Archives and not Streams #460

mgerhardy opened this issue May 6, 2024 · 0 comments · Fixed by #461
Labels
enhancement

Comments

@mgerhardy
Copy link
Collaborator

For multi file based formats it would be better to use an io::Archive here to being able to directly create new write streams in the archive and not write any files. Currently a lot of cases like io::filesystem()->open(extFilename, io::FileMode::SysWrite) exists in the Format implementations.

to name a few

  • VXL/HVA
  • VXR/VXM/VXA/png
  • Minecraft regions for dat files

there are other formats that out sourced their screenshot or metadata or anything like that.

See e.g. VMaxFormat::loadGroupsPalette - locations like these could benefit, too

Also see #434
mgerhardy added a commit that referenced this issue May 8, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
f6e50b0 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
@mgerhardy mgerhardy mentioned this issue May 8, 2024
Merged
4 tasks
mgerhardy added a commit that referenced this issue May 8, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
e595ce5 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 8, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
183ebb5 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 8, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
a7fdc59 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 8, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
b861a9e 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
@mgerhardy mgerhardy linked a pull request May 8, 2024 that will close this issue
VOXELFORMAT: refactored interface to work with archives and not on st… #461
Merged
4 tasks
mgerhardy added a commit that referenced this issue May 9, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
fc29a1d 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 10, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
36ddce4 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 13, 2024
@mgerhardy
IO: changed archive interface to work with raw pointers
496b5a9 
preparation for issue #460
mgerhardy added a commit that referenced this issue May 13, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
9a558d1 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 13, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
202c188 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 13, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
0c3281a 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 13, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
f16f3d5 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 14, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
dd40894 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 14, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
3ffcb29 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 14, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
13ea401 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
mgerhardy added a commit that referenced this issue May 14, 2024
@mgerhardy
VOXELFORMAT: refactored interface to work with archives and not on st…
2ad15c8 
…reams

this allows us to support multi file formats in a better way

Fixes issue #460
@mgerhardy mgerhardy mentioned this issue May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VOXELFORMAT: refactored interface to work with archives and not on st… vengi-voxel/vengi
1 participant
@mgerhardy