Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding - README instructions are out of date / incorrect #845

Open
1 task done
happybeing opened this issue Feb 17, 2020 · 0 comments
Open
1 task done

Embedding - README instructions are out of date / incorrect #845

happybeing opened this issue Feb 17, 2020 · 0 comments

Comments

@happybeing
Copy link

Please:

  • Check for duplicate issues

The Embed Voyager instructions in the README need updating.

  1. The const libVoyager = require('voyager'); may be incorrect as the import was undefined. When embedding in my Svelte test I successfully used:
import {Voyager, CreateVoyager} from 'datavoyager';
  1. When embedding there are a number of missing dependencies including node-sass and font-awesome.

  2. The styles.css doesn't appear to be present in the voyager repo, so I copied it from voyager/node_modules/datavoyager/dist.

Voyager is great, thank you very much. Hope the above helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant