Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q Filter: Plot Color Updates, but the Legend Doesn't #821

Open
light-and-salt opened this issue Jun 13, 2018 · 0 comments
Open

Q Filter: Plot Color Updates, but the Legend Doesn't #821

light-and-salt opened this issue Jun 13, 2018 · 0 comments

Comments

@light-and-salt
Copy link
Contributor

Filter Acceleration 8-25:
screen shot 2018-06-13 at 2 44 25 pm

Filter Acceleration 8-11:
screen shot 2018-06-13 at 2 45 27 pm

Looks like the color scales in the plots have indeed updated to 8-11, but the color legends are still 8-25.

I can see two options going forward:

(a) On the one hand, I think there are some benefits to hold the color scales constant (always set the color scale domain to the raw data domain). This way, when the user changes the Q filter, the mark colors will be consistent across time. The same marks will always have the same color. If we choose to go this way, we need to set the color scale domain in plots to always use raw data domain despite filters.

(b) On the other hand, each single plot will use color more effectively if we don't hold color scale domains constant. If we choose to go this way, we need to fix the color legend to correctly reflect the filtered scale domain.

@light-and-salt light-and-salt changed the title Q Filter Updates Colors Scale Domains But Not Color Legends Q Filter: Plot Color Updates, but the Legend Doesn't Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant