Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try different validator #3

Open
domoritz opened this issue Dec 3, 2017 · 5 comments
Open

Try different validator #3

domoritz opened this issue Dec 3, 2017 · 5 comments

Comments

@domoritz
Copy link
Member

domoritz commented Dec 3, 2017

From https://github.com/vega/vega-editor/issues/191

We would like

  • Better error messages
  • Links to the editor from an error
@nyurik
Copy link
Member

nyurik commented Feb 21, 2018

Would be awesome if the editor also supported hjson - much better for writing it - allows comments, not as strict as json, etc.

@domoritz
Copy link
Member Author

@nyurik We had this discussion many times. I only want to support more languages if we don't cause confusion with the docs(excludes yaml) and supports autocomplete in the editor (which excludes hjson, I think). But I agree that JSON is a terrible language for people to write.

@nyurik
Copy link
Member

nyurik commented Feb 21, 2018

I guess I might have to invest into hjson schema validator and autocomplete module ... will see :)

@domoritz
Copy link
Member Author

domoritz commented Mar 16, 2020

It would be good if we could use validator with better error messages. Right now, we use AJV and the error messages are not very helpful in most cases (#643)

@domoritz
Copy link
Member Author

domoritz commented Mar 16, 2020

Maybe a simple option would be to just read the error messages from Monaco and get rid of ajv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants