Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data dependencies are not shown in dataflow viewer #1215

Open
domoritz opened this issue Jul 1, 2022 · 3 comments
Open

Data dependencies are not shown in dataflow viewer #1215

domoritz opened this issue Jul 1, 2022 · 3 comments

Comments

@domoritz
Copy link
Member

domoritz commented Jul 1, 2022

Open the Chart in the Vega Editor

Screenshot 2022-07-01 at 4 01 49 PM

I would expect to see a connection between the table and the derived data source.

@domoritz
Copy link
Member Author

domoritz commented Jul 1, 2022

@saulshanabrook can you help fix this or explain why this connection isn't there?

@saulshanabrook
Copy link
Contributor

Thanks for the question @domoritz.

I am looking at the dataflow now (from VEGA_DEBUG.vega.parse(VEGA_DEBUG.vegaSpec) and the data parts are currently created from inputs from different operators:

Screen Shot 2022-07-02 at 9 59 45 AM

So just from the structure of the dataflow graph, it isn't clear to me how the "derived" data set has a source of the table. It looks like the answer might be the relay operator since it connects those two?

From a quick look at the vega parser logic for the data, it does seem like it makes a relay operator when you add a source to a data set.

Currently, the dataflow viewer does not special case any of the operators to show them differently in the graph, so it treats the relay operator just like the others.

@domoritz
Copy link
Member Author

domoritz commented Jul 2, 2022

Ah, I see. Thank you for digging into the question.

I wonder whether it would make sense to special case the direction of the edges for these operators. @jheer @arvind what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants