Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images scale to the timeline width #8011

Closed
turt2live opened this issue Jan 3, 2019 · 4 comments
Closed

Images scale to the timeline width #8011

turt2live opened this issue Jan 3, 2019 · 4 comments
Assignees
@bwindels
Labels
A-Media A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

It would be great to get the best of a wider timeline and not have images which consume the entire view.

Related: #1520
@turt2live turt2live mentioned this issue Jan 11, 2019
Closed
@bwindels bwindels self-assigned this Feb 12, 2019
@lampholder lampholder added P2 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline A-Media T-Defect and removed redesign labels Mar 12, 2019
@ara4n
Copy link
Member

ara4n commented Apr 9, 2019

We currently cap images at 600px high to prevent them from stealing lots of screen width. They will only scale horizontally to fit the whole timeline if it doesn't waste height.

@nadonomy do you think we should also cap the width too?

@ara4n
Copy link
Member

ara4n commented Apr 9, 2019

see also #1520

@nadonomy
Copy link
Member

@nadonomy do you think we should also cap the width too?

Yeah. The bigger the images can get the less comfortable your gaze is when scanning and reading messages.

I'd argue for a max width/height of around 400px even, treating them as large thumbnails in the knowledge users can browse messages more comfortably and view them in a full screen lightbox to see more detail.

@turt2live
Copy link
Member Author

There's now an image size setting (on develop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-Media A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bwindels @turt2live @ara4n @lampholder @nadonomy