Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replying to a message containing a ping causes the intended recipient(s) of the ping to be pinged again #7874

Open
n-o-o-b opened this issue Dec 16, 2018 · 3 comments · May be fixed by matrix-org/matrix-react-sdk#6964

Comments

@n-o-o-b
Copy link

n-o-o-b commented Dec 16, 2018

This happens for both room pings and user pings. Examples:

image
(As seen by users other than Ruff_Wizard. User Ruff_Wizard does not get themself pinged by their reply, but the rest of the room does.)

image
(As seen by user Ruff_Wizard. User Ruff_Wizard gets pinged by a message replying to one containing their name.)

It shouldn't work like this; this system assumes that someone necessarily wants/needs to get pinged just because another person is replying to a message which contains their name/a room ping. If someone wants to ping the person or the room again, they can simply insert another ping in the text of their reply. The system shouldn't ping every time the intial ping is replied to.

@n-o-o-b n-o-o-b changed the title Replying to a message with a ping causes the intended recipient(s) of the ping to be pinged again Replying to a message containing a ping causes the intended recipient(s) of the ping to be pinged again Dec 16, 2018
@t3chguy
Copy link
Member

t3chguy commented Dec 16, 2018

This'll automatically be fixed once the fallback is removed from the replies

@lieuwex
Copy link

lieuwex commented Aug 14, 2020

Is there any reason why homeservers don't first strip the fallback before checking for push rules?

@t3chguy
Copy link
Member

t3chguy commented Aug 17, 2020

That's up to the homeserver, not Element, would recommend you take your question to whatever homeserver you are wishing did that (really though it would have to be specced as such because clients apply push rules too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants