Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does setPredictor prevent empty leaf-nodes? #50

Open
EoghanONeill opened this issue Sep 12, 2022 · 0 comments
Open

Why does setPredictor prevent empty leaf-nodes? #50

EoghanONeill opened this issue Sep 12, 2022 · 0 comments

Comments

@EoghanONeill
Copy link

If there are empty leaf-nodes, the likelihood for the Metropolis-Hastings step can still be calculated, and the means for the empty leaf-node parameter draws are equal to zero (the prior mean). Is there a reason this is considered to be invalid?

Is it possible to add an option that allows for empty leaf-nodes?

Also I can find updatePredictor in https://github.com/vdorie/dbarts/blob/main/src/dbarts/bartFit.cpp , but I cannot find it in https://cran.r-project.org/web/packages/dbarts/dbarts.pdf . Which is the correct function to use when setting new values for the predictors in each MCMC iteration, setPredictor or updatePredictor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant