Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-14-rbart "is reproducible" is not reproducible #48

Open
jeffreyoldham opened this issue Jul 12, 2022 · 0 comments
Open

test-14-rbart "is reproducible" is not reproducible #48

jeffreyoldham opened this issue Jul 12, 2022 · 0 comments

Comments

@jeffreyoldham
Copy link

The recently added "is reproducible" test in test-14-rbart.R can fail depending on the order of random bits. An easy fix would be to set the seed at the beginning of the test, before rbart_vi calls. A better fix would be to test so any random bit order would permit the test to pass.

More details: Tests may be executed in various orders by test harnesses so assuming tests run in a particular order is likely to lead to failures. Running the test by hand in isolation does work for me. Running inside a test harness does not.

Some of the tests in this file do correctly set a seed at the start of the test. Others do not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant