Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Share Button #95

Open
antgiant opened this issue Jun 29, 2023 · 3 comments
Open

Feature Request: Share Button #95

antgiant opened this issue Jun 29, 2023 · 3 comments

Comments

@antgiant
Copy link

antgiant commented Jun 29, 2023

I love this and wanted the ability to pre-setup a link to share with others for their location, but that doesn't seem to be possible currently. Would you be willing to add a share button that lets you include the location and preference data? Even just something as simple as a basic as a dump of current form state in URL form would be great. For instance https://battaglia.ddns.net/twc/?txtAddress=[address]&radEnglish=[selection]&chkAutoRefresh=[true/false]&radThemes=[selection]&radScroll=[selection]&radScrollText=[text]&chkScrollHazardText=[true/false]&fullScreen=[true/false]

@vbguyny
Copy link
Owner

vbguyny commented Jul 3, 2023

Hello @antgiant,

Not a bad idea, I don't have the time to work on this exactly the way you explained, but there is a way to share your location manually. Please refer to #68

@antgiant
Copy link
Author

antgiant commented Jul 4, 2023

If I find time to add it would you be open to a pull request?

My thought is to add an on page load hook that takes the URL parameters and moves them to the form locations in a way that triggers the existing onChange hooks. Should be minimally invasive while accomplishing the goal.

Then adding a share button that simply displays current form state as a url.

@vbguyny
Copy link
Owner

vbguyny commented Jul 4, 2023

Sure ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants