Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker deployment with bazel-defined version tag #360

Open
flyingsilverfin opened this issue Nov 11, 2022 · 0 comments
Open

Docker deployment with bazel-defined version tag #360

flyingsilverfin opened this issue Nov 11, 2022 · 0 comments

Comments

@flyingsilverfin
Copy link
Member

Problem to Solve

To make a consistent API within this repository, we can create a variant of @io_bazel_rules_docker//container:container.bzl's container_push which instead of taking a tag argument, reads from the defined variables in the context.

We should also allow differentiating the docker-tag version from the standard version tag that is used elsewhere, so that the deployment tag doesn't have to be the exact same as the version number written into the distribution archive.

Current Workaround

We define the docker tag into a VERSION file, which is read into the target in BUILD files.

Proposed Solution

We create a container push rule that allows to define the tag name to deploy against using a --define container-tag=<VERSION> in the invocation of the build rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant