Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rules_pkg patch to allow long filenames is fragile #355

Open
lukas-slezevicius opened this issue Sep 20, 2022 · 0 comments
Open

The rules_pkg patch to allow long filenames is fragile #355

lukas-slezevicius opened this issue Sep 20, 2022 · 0 comments

Comments

@lukas-slezevicius
Copy link

Users of bazel-distribution, such as TypeDB, depend on the fact that tar.gz assembly works with long filenames. Older versions of rules_pkg have an issue that prevents tar.gz assembly from working with long filenames, however, a patch implemented in bazel-distribution fixes that problem.

The problem with using a patch to solve this problem is that it is very fragile for a commonly used dependency such as rules_pkg. If another dependency that transitively depends on rules_pkg, such as rules_docker, is loaded first, then we end up loading an unpatched version of rules_pkg into our workspace, which brings back the long filename issue. We have encountered this problem recently in TypeDB (see vaticle/typedb#6644).

Upgrading rules_pkg directly is not possible because of stardoc not working with more recent versions of rules_pkg. Similar issue was encountered in #251.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant