-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vsl-query: floats do not behave as expected #4088
Comments
It looks to me like this might be related to use of SF_Parse_Decimal() since 05e10ee. Questions: Are structured field semantics a good fit for vsl queries?
Edit: I was wrong in the above. In the example, both Numbers 84.677353 and 84.677 get rounded to 84.677, such that |
In retrospect, SF_Parse_Decimal() is too brutal for delta-T values in VSL records. |
from 1:1 conversation with phk: we should probably just use |
It seems I wrongly assumed strtoll(".", ...) would return 0, so bring back the fallack to float parsing similar to what we had before 05e10ee. Should fix regression on FreeBSD from 0dfa3b8 Also clean up now unneeded include (thank you, Flexelint). Fixes #4088 I promise, if this is still wrong, I will install FreeBSD ;)
Expected Behavior
Comparisons involving floats should behave as documented:
Current Behavior
Comparisons fail in unexpected ways
OK:
not OK:
Possible Solution
No response
Steps to Reproduce (for bugs)
No response
Context
Varnish Cache version
No response
Operating system
No response
Source of binary packages used (if any)
No response
The text was updated successfully, but these errors were encountered: