New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message setting doesn't work #72
Comments
Hm, strange. I can't seem to repro. Can you share the output of this command?
|
Sure Thing:
|
If there is no .noti.yaml in the folder you are in when you run noti, it ignores the message flag. creating a empty .noti.yaml file fixes the problem but only for that given directory. the issue might here: noti/internal/command/config.go Lines 182 to 192 in 960a214
|
Creating an empty file |
Ooooh, nice! I can definitely reproduce this now! Thanks @heidark! Patch release will be coming soon! |
Currently, if you don't have a noti config file, setting the notification message with --message doesn't work. This is because noti stops configuration after reading the config file fails. This change just logs that error instead of returning, since it's a non-fatal error. It also fixes the unit test that should have caught this. Resolves #72
Thanks everyone! Closing now. Patch release will be coming soon! |
Description
The
--message
/-m
flag is not correctly setting the message field of notifications. No matter what is specified, the message field is always the string "Done!".Steps to reproduce
This behaviour occurs when the configuration file is missing. An empty file resolves it, as pointed out by @heidark.
Expected behavior
The message field of notification popups / voice readouts to be "My Message".
Actual behavior
The message fields remains the default string "Done!".
Version
3.0.0
, installed via Homebrew on MacOs 10.13.2The text was updated successfully, but these errors were encountered: