Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate bindings for Node.js #14

Open
venediktov opened this issue May 3, 2018 · 0 comments
Open

generate bindings for Node.js #14

venediktov opened this issue May 3, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@venediktov
Copy link
Member

venediktov commented May 3, 2018

Currently we provided simple general binging code to access C++14 bidder via main function
, however for ppl to write logic in JavaScript I think we need the following :

  • Add --bindings flag to bid_generator.go
  • New codegen/bindings_generator.go
  • Generate Node.js C++ wrapper function arround C++ matching functions see generated bidder.cpp.
  • Provide minimum example on bidder.js how to use those newly generated Node C++ functions in JavaScript. Because JavaScript layer does not yet have fwk/rtb/core/ad_selector.hpp with chained_selector class implementation, therefore developers will have to write javascript logic by hand, however chained_selector.js can be implemented , so the use case in bidder.js will be similar as in generated bidder.cpp

This is still Can we do it type of issue , needs evaluation from node.js ppl.

@venediktov venediktov added enhancement New feature or request help wanted Extra attention is needed labels May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant