Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A different angle towards telnet #838

Open
margaretjansen opened this issue Apr 11, 2023 · 1 comment
Open

A different angle towards telnet #838

margaretjansen opened this issue Apr 11, 2023 · 1 comment

Comments

@margaretjansen
Copy link

I'm happy to do the dev. just not sure this repo is really the latest...
So on the specific tab, you have the option to include a success login string. I know you can to nmap -sV and get detail, but that detail does not always reveal the exact string to expect.
How about adding a negative.
When you target a host, you know exactly what the denied message looks like. So having a negative response makes more sense to detect a failure. a pass would be anything that does not look like the failure message. I think this is a better way to deal with false positives.
Case in point... Chinese ipcams. They use some very custom busybox setups. success is not always just ~# or ~$
But the failure is always consistent.

@vanhauser-thc
Copy link
Owner

Initially the implementation was like that, but the issue is that packets get lost, timeouts occur, devices behave erratically etc and then final packet gets lost and a false positive is detected resulting in stop of the test.

If you want to implement it though go for it and I will merge the PR. It just should be optional, it cannot be the new default :)

Repository owner deleted a comment from Mhagne May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants