Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incidents list pagination #2

Open
valtlfelipe opened this issue Oct 7, 2020 · 7 comments
Open

Incidents list pagination #2

valtlfelipe opened this issue Oct 7, 2020 · 7 comments
Labels
enhancement New feature or request hacktoberfest
Projects
Roadmap

Comments

@valtlfelipe
Copy link
Owner

valtlfelipe commented Oct 7, 2020 •
edited

Add pagination to incidents and maintenances lists.
Statuspage API doc: https://developer.statuspage.io/#operation/getPagesPageIdIncidents
@valtlfelipe valtlfelipe created this issue from a note in Roadmap (New releases) Oct 7, 2020
@valtlfelipe valtlfelipe added enhancement New feature or request hacktoberfest labels Oct 7, 2020
@navinkumar-k-015
Copy link
Contributor

I added pagination
test2

@navinkumar-k-015
Copy link
Contributor

but I ran into a problem whenever I refresh, the old list remains and a new whole list gets added below it.

@navinkumar-k-015
Copy link
Contributor

test3

@valtlfelipe
Copy link
Owner Author

How are you querying the API? Because there is a limit and a page property.
The limit should be a fixed value, the page should only incremente for each new page, and the API will return only new data, which you then push to the current array of this view.

@navinkumar-k-015
Copy link
Contributor

yeah I am using that only
'

@navinkumar-k-015
Copy link
Contributor

I will create a pull a pull request to show

@valtlfelipe
Copy link
Owner Author

Could you please open a draft pull request, so I can have a look and help you better.

@valtlfelipe valtlfelipe moved this from New releases to To do in Roadmap Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest
Projects
Roadmap
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valtlfelipe @navinkumar-k-015