Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (9ebbd5f) to head (bac2529).
Report is 6 commits behind head on unstable.

❗ Current head bac2529 differs from pull request most recent head ebe3eb3. Consider uploading reports for the commit ebe3eb3 to get more accurate results

@@             Coverage Diff              @@
##           unstable     #441      +/-   ##
============================================
+ Coverage     68.40%   68.45%   +0.04%     
============================================
  Files           109      109              
  Lines         61673    61673              
============================================
+ Hits          42189    42219      +30     
+ Misses        19484    19454      -30     

Thanks for helping, it looks like some of the tests are failing. Did you run:

make valkey-unit-tests
./src/valkey-unit-tests 

To make sure they all run?

No i don't do that. I fix the tests and push it again.

Hi. I fix some problems but there is some bigger problems.
for test_dict for example we want to use dict_force_resize_ratio variable but it is declared in .c file and not in header. What should i do? can i move this thing to header or there is a trick to include this type of thing only in test?
another problem is that some functions and # defines are also in .c file.

for test_dict for example we want to use dict_force_resize_ratio variable but it is declared in .c file and not in header. What should i do? can i move this thing to header or there is a trick to include this type of thing only in test?
another problem is that some functions and # defines are also in .c file.

For other tests like listpack we've just been including the .c file. Since some other folks have already ported some of the other tests, do you mind just re-submitting the PR just for the dict.c test case? It's a bit easier to merge as well.