New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CLUSTER SETSLOT ... TIMEOUT 0 bypass the wait #422
Comments
|
Maybe it would be better to validate the value. Just as it would be counter-intuitive for a value of zero to default to 2, wouldn't it be counter-intuitive for a value of 0 to disable the feature? |
I think it is intuitive that TIMEOUT 0 means don't wait at all. (That's what disable the feature means.) |
@madolson you argued that there might be uses cases for disabling the feature. What other syntax would you suggest for that, if not TIMEOUT 0? I don't think there's any use case for infinite wait. |
The only other option I would consider is -1, but I suppose I don't feel all that strongly. I'm okay with either option. |
-1 = infinity then? ;)
|
Follow-up of #245.
TIMEOUT 0 is interpreted as the default value (2 seconds?) which is counter-intuitive given that TIMEOUT 1 is 1ms.
It's better that TIMEOUT 0 bypasses replication-before-execution.
@madolson wrote
Original discussion: #245 (comment)_
The text was updated successfully, but these errors were encountered: