Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make implicit ACL categories explicit in JSON files #417

Open
zuiderkwast opened this issue May 2, 2024 · 0 comments
Open

Make implicit ACL categories explicit in JSON files #417

zuiderkwast opened this issue May 2, 2024 · 0 comments

Comments

@zuiderkwast
Copy link
Contributor

zuiderkwast commented May 2, 2024

The JSON files describing the commands include ACL categories, but these are not the final ACL categories used. Valkey adds some implicit ones depending on "command flags" which are also from the same JSON files.

To remove this discrepancy and make the JSON files more usable as-is, we'd need:

  • Add all implicit ACL categories in the JSON files,
  • Validate that the JSON files follow the rules for implicit ACL categories. This can be done in utils/generate-command-code.py.
  • Remove the code that adds implicit ACL categories, the function setImplicitACLCategories() in
    server.c.

This is a follow-up of #403.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant