Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyright/licensing feedback #32

Open
andhe opened this issue Jan 25, 2020 · 1 comment
Open

copyright/licensing feedback #32

andhe opened this issue Jan 25, 2020 · 1 comment

Comments

@andhe
Copy link
Contributor

andhe commented Jan 25, 2020

Hello,

While preparing a package of garagemq for Debian I had to investigate the licensing and copyright status in great details. I'd like to provide some feedback from my findings of some things that are problematic for Debian and some details you might want to make more clear that might benefit others.

  • The readme/*.jpg screenshots seems to contain an embedded ICC profile in their EXIF data which Apple claims copyright on. It's not clear which license these are provided under (if any?).[1] It would be nice if you could strip off the ICC profile from the images to save us the time having to think about legality of redistributing your screenshots.
  • LICENSE mentions your copyright and license, but it could possibly be nice to more clearly/explicitly point out that protocol/*.xml has a different copyright holder and license.
  • You spell your name diffently in LICENSE vs in the source (which makes your preference of how to be attributed in the Debian package copyright non-obvious), might want to make it consistent? (first last vs last first) :)
  • Possibly point out that admin-frontend/build directory contains compiled/obfucated nodejs files -- without providing the corresponding source files in the garagemq repository.[2]

[1]: Apple copyright claims in readme/*.jpg

$ grep -i copyright readme/*.jpg
Binary file readme/channels.jpg matches
Binary file readme/connections.jpg matches
Binary file readme/exchanges.jpg matches
Binary file readme/overview.jpg matches
Binary file readme/queues.jpg matches
$ for a in readme/*.jpg ; do echo ===== $a ; identify -verbose $a  | grep -i copy ; done
===== readme/channels.jpg
    icc:copyright: Copyright Apple Inc., 2018
===== readme/connections.jpg
    icc:copyright: Copyright Apple Inc., 2018
===== readme/exchanges.jpg
    icc:copyright: Copyright Apple Inc., 2018
===== readme/overview.jpg
    icc:copyright: Copyright Apple Inc., 2018
===== readme/queues.jpg
    icc:copyright: Copyright Apple Inc., 2018

[2]: In Debian, and probably more places, this is problematic for two reasons. a/ a clear separation between "source" (preferable form of modification) and built files are desired. b/ corresponding source (and its licenses) must always be available to be allowed into Debian.

@valinurovam
Copy link
Owner

valinurovam commented Apr 22, 2023

@andhe thx for feedback
Fixed issues about licence and icc profile #87

LICENSE mentions your copyright and license, but it could possibly be nice to more clearly/explicitly point out that protocol/*.xml has a different copyright holder and license.

How should I mention about protocol?

Possibly point out that admin-frontend/build directory contains compiled/obfucated nodejs files -- without providing the corresponding source files in the garagemq repository.[2]

Source files provided into the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants