Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second pass for matrix's unconnected pairs #4474

Closed
nilsnolde opened this issue Dec 23, 2023 · 1 comment · Fixed by #4536
Closed

second pass for matrix's unconnected pairs #4474

nilsnolde opened this issue Dec 23, 2023 · 1 comment · Fixed by #4536

Comments

@nilsnolde
Copy link
Member

Discovered in TomTom data, couldn't find a proper example in OSM for this. The same request works with OSM which might just be because in OSM there's a few more ways in that not_thru region to carry it over the 256 node limit beyond which we assume not_thru = false. But that's just a guess so far. Need to investigate further.

@nilsnolde
Copy link
Member Author

Nope, it's not that.. In fact it's a very bad case, where both trees hit a different no_thru edge. /route only works on a second pass as well, after disabling no_thru. 2 things we should do anyways, both of which would make this matrix call work:

  1. set not_thru for all edges in region #3812: mark all edges inside a no_thru region
  2. Re-run the matrix only for unconnected pairs in a second pass, just like /route.

Both should be done eventually. I'd prefer to do 2. first, it'd have a bigger impact for matrix, also destonly, hierarchy limit relaxing etc could be dealt with.

@nilsnolde nilsnolde changed the title costmatrix can't handle not_thru edges second pass for matrix's unconnected pairs Dec 27, 2023
This was referenced Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant