Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General lighthouse test improvements #359

Open
BeneRichi opened this issue Jan 19, 2024 · 0 comments
Open

General lighthouse test improvements #359

BeneRichi opened this issue Jan 19, 2024 · 0 comments
Assignees
@BeneRichi
Labels
enhancement New feature or request
Projects
Vue Template

Comments

@BeneRichi
Copy link
Contributor

Please add the missing role attribute on the <li> element which is the parent of the <a> in c-tabs.vue

     <li v-for="tab in tabs"
            :key="tab.id"
            :class="b('tab-item')"
            role="tabitem"
        >
@BeneRichi BeneRichi added the enhancement New feature or request label Jan 19, 2024
@BeneRichi BeneRichi self-assigned this Jan 19, 2024
@BeneRichi BeneRichi added this to To do in Vue Template via automation Jan 19, 2024
@BeneRichi BeneRichi moved this from To do to In progress in Vue Template Jan 19, 2024
@BeneRichi BeneRichi changed the title Add "role" on <li> element in c-tabs component. General lighthouse test improvements Jan 19, 2024
@BeneRichi BeneRichi mentioned this issue Feb 20, 2024
Merged
12 tasks
mob8607 added a commit that referenced this issue May 6, 2024
@mob8607
Merge pull request #365 from valantic/feature/359_General_improvement…
43e5088 
…s_lighthouse_testing

#359 General improvements lighthouse testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeneRichi BeneRichi

Labels
enhancement New feature or request
Projects
Vue Template
In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BeneRichi