Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e-date and c-date-picker #131

Closed
patric-eberle opened this issue Jan 15, 2021 · 2 comments
Closed

e-date and c-date-picker #131

patric-eberle opened this issue Jan 15, 2021 · 2 comments
Assignees
@patric-eberle
Labels
components New components to add or enhancements on exiting components enhancement New feature or request high priority vue-3 Will only be done for the vue-3 version
Projects
Vue Template

Comments

@patric-eberle
Copy link
Member

patric-eberle commented Jan 15, 2021 •
edited by BeneRichi

For IV we created two new components to handle date inputs. Since they contain no specific functionality (except for v-focus), it should be save to copy them into the boilerplate.

e-date

  • Accepts a date string and returns a date object
  • Date string format is based on the users sytem settings
  • Can have an inline label and icon if required

c-date-picker

  • Uses Pikaday
  • Allows to select a single date or a range of dates

e-input

  • Make sure internalValue gets updated when input value changes (watch)
@patric-eberle patric-eberle added the enhancement New feature or request label Jan 15, 2021
@janwidmer janwidmer added the components New components to add or enhancements on exiting components label Oct 5, 2021
@patric-eberle patric-eberle pinned this issue Mar 26, 2022
@patric-eberle patric-eberle added this to To do in Vue Template Jan 5, 2023
@patric-eberle patric-eberle added vue-3 Will only be done for the vue-3 version vue-2 Will only be needed for vue-2 labels Jan 6, 2023
@BeneRichi BeneRichi moved this from To do to In progress in Vue Template Jan 9, 2023
BeneRichi added a commit that referenced this issue Jan 10, 2023
@BeneRichi
#131 Add existing components + scss and helper files
6b2a16c
BeneRichi added a commit that referenced this issue Jan 10, 2023
@BeneRichi
#131 Add translation strings for date picker labels
2e42016
BeneRichi added a commit that referenced this issue Jan 10, 2023
@BeneRichi
#131 Remove rem method from margin style
6924d63
BeneRichi added a commit that referenced this issue Jan 10, 2023
@BeneRichi
#131 Use pikaday dependency styles and add rem function file
95213ad
BeneRichi added a commit that referenced this issue Jan 10, 2023
@BeneRichi
#131 Add danger color state for theme(s)
46109af
BeneRichi added a commit that referenced this issue Jan 10, 2023
@BeneRichi
#131 Add date-picker components to test them with v-model
c44f26e
@BeneRichi BeneRichi moved this from In progress to Code Review in Vue Template Jan 12, 2023
@BeneRichi BeneRichi assigned patric-eberle and unassigned BeneRichi Jan 12, 2023
@patric-eberle patric-eberle moved this from Code Review to In progress in Vue Template Jan 19, 2023
BeneRichi added a commit that referenced this issue Jan 20, 2023
@BeneRichi
#131 Add translations for c-date-picker labels inside the calendar
a646146
BeneRichi added a commit that referenced this issue Jan 20, 2023
@BeneRichi
#131 Add new grayscale--800 shade to match the pickaday dependency style
f02bb4a
BeneRichi added a commit that referenced this issue Jan 20, 2023
@BeneRichi
#131 Add range attribute, dynamic :start.sync and :end.sync props on …
4494ecf 
…<cDatePicker /> - rename form data properties to startDate and endDate and make them equal with today's date as default
BeneRichi added a commit that referenced this issue Jan 20, 2023
@BeneRichi
#131 Removed rem() function on both components - declare the width an…
dbe76e9 
…d height of an e-icons with the size attribute - separate nested if statements to simplify readability - rewrite comments
@BeneRichi BeneRichi moved this from In progress to Code Review in Vue Template Jan 20, 2023
@BeneRichi BeneRichi moved this from Code Review to In progress in Vue Template Jan 20, 2023
BeneRichi added a commit that referenced this issue Jan 20, 2023
@BeneRichi
#131 Defined "month" template and stored it in "const dateTimeFormats…
1f3f7f1 
…" to be used inside the options object in the new VueI18n instance - call i18n.setDateTimeFormat() after fetching current page locale
BeneRichi added a commit that referenced this issue Jan 20, 2023
@BeneRichi
#131 Defined "month, weekday and weekdayNarrow" template and stored i…
7776793 
…t in "const dateTimeFormats" to be used inside the options object in the new VueI18n instance - call i18n.setDateTimeFormat() after fetching current page locale
BeneRichi added a commit that referenced this issue Jan 20, 2023
@BeneRichi
#131 Removed spacing to resolve ESlint warning
43f10f4
@BeneRichi BeneRichi moved this from In progress to Code Review in Vue Template Jan 25, 2023
@BeneRichi BeneRichi moved this from Code Review to In progress in Vue Template Jan 25, 2023
BeneRichi added a commit that referenced this issue Jan 30, 2023
@BeneRichi
#131 Updated comment from "min" to "max" - added line break (space) a…
e85ad15 
…fter code block - removed duplicated keypress event - changed background color of date fields from color-grayscale-800 to 600 - changed color of date input field's labels - removed color shade 800 from _color.scss - move static attribute without value after static one with value - add form.date value property to make it a directive - changed input field width

Signed-off-by: BeneRichi <benedict.ritschel@cec.valantic.com>
@BeneRichi BeneRichi moved this from In progress to Code Review in Vue Template Feb 1, 2023
@BeneRichi BeneRichi moved this from Code Review to In progress in Vue Template Feb 1, 2023
BeneRichi added a commit that referenced this issue Feb 1, 2023
@BeneRichi
#131 Change $color-grayscale--700 to $color-grayscale--600 - remove $…
c72db4f 
…color-grayscale--700 from _color.scss to reduce color classes

Signed-off-by: BeneRichi <benedict.ritschel@cec.valantic.com>
@BeneRichi BeneRichi moved this from In progress to Code Review in Vue Template Feb 1, 2023
@BeneRichi BeneRichi assigned patric-eberle and unassigned BeneRichi Feb 1, 2023
patric-eberle added a commit that referenced this issue Feb 3, 2023
@patric-eberle
#131 removes keyboard support for c-date-picker, since it breaks the …
4e8a009 
…component
@patric-eberle patric-eberle removed the vue-2 Will only be needed for vue-2 label Feb 3, 2023
@patric-eberle patric-eberle moved this from Code Review to To do in Vue Template Feb 3, 2023
@patric-eberle
Copy link
Member Author

Can also be merged to Vue 3.

@BeneRichi BeneRichi moved this from To do to In progress in Vue Template Feb 6, 2023
BeneRichi added a commit that referenced this issue Feb 7, 2023
@BeneRichi
#131 Resolves a naming convention issue in i18n.js - imports necessar…
7500e2b 
…y eIcon element
@BeneRichi BeneRichi moved this from In progress to Code Review in Vue Template Feb 7, 2023
@BeneRichi BeneRichi moved this from Code Review to In progress in Vue Template Feb 8, 2023
BeneRichi added a commit that referenced this issue Feb 8, 2023
@BeneRichi
#131 Adds c-date-picker.vue with type declaration - enables day.js pl…
17ad5eb 
…ugin - adds get-localized-date-format.ts and add type declaration - installs @types/pikaday dependency
@patric-eberle
Copy link
Member Author

Vue 2 variant is available, but it was not migrated to Vue 3.

@patric-eberle patric-eberle mentioned this issue Dec 13, 2023
Closed
@patric-eberle patric-eberle moved this from In progress to Done in Vue Template Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patric-eberle patric-eberle

Labels
components New components to add or enhancements on exiting components enhancement New feature or request high priority vue-3 Will only be done for the vue-3 version
Projects
Vue Template
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janwidmer @BeneRichi @patric-eberle @MB-web