Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization 'ru' works incorrect #103

Open
akhatmullin opened this issue Oct 8, 2018 · 4 comments
Open

Localization 'ru' works incorrect #103

akhatmullin opened this issue Oct 8, 2018 · 4 comments

Comments

@akhatmullin
Copy link

When I try to generate a first name using the 'ru' localization I receive first names for the 'en' localization.
@vadymmarkov
Copy link
Owner

@akhatmullin How do you create an instance of Faker class? Is it let faker = Faker(locale: "ru")?

@akhatmullin
Copy link
Author

@vadymmarkov Yes, it is.

@akhatmullin
Copy link
Author

@vadymmarkov I use version 3.4.0
I looked at the code a little bit and my suggestion that there is a different JSONs structure.
For example, we have the array of first names as "first_name" for "en" locale, but we have "male_first_name" for "ru" locale.

@vadymmarkov
Copy link
Owner

Nice catch, that's probably it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akhatmullin @vadymmarkov