New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuck in an invalid state #830
Comments
This seems to be a bug in I think dynamically changing The validation considers The problem seems to be that when you only have one of those validation constraints set (e.g. I think the proper logic here would be to observe when any of |
This can be reproduced with <vaadin-text-field required="{{tfRequired}}"></vaadin-text-field><br>
<label>Required <input type="checkbox" checked="{{tfRequired::change}}"></label>
|
I opened an issue about this here vaadin/vaadin-text-field#400 but I'll leave this combo box issue here for better visibility if someone else notices the issue with combo box. This should be closed after the above text field issue is fixed. |
I can confirm it is working as expected now. Thanks voor the good work, @Haprog! 😄 |
Btw. afaik the WebJars for |
Description
When a
vaadin-combo-box
is required and thevaadin-combo-box
has been selected, but nothing is chosen, the innervaadin-text-field
will be marked as invalid when deselecting thevaadin-combo-box
. However, if the required attribute is removed in the meantime, the innervaadin-text-field
is still in the invalid-state.Expected outcome
Changing attributes (or at least the required attribute) on the
vaadin-combo-box
should trigger a revalidation of the underlyingvaadin-text-field
.Actual outcome
The
vaadin-text-field
is stuck in an invalid state. The form can't be submitted because of this invalid state.Live Demo
https://ring-umbra.glitch.me
Steps to reproduce
vaadin-combo-box
. The options will be display, but do not select an item (click somewhere in the white space)vaadin-combo-box
will color red and is in an invalid state.vaadin-combo-box
will remain in an invalid statevaadin-combo-box
vaadin-combo-box
: thevaadin-combo-box
is still in an invalid state, although it is no longer required.Changing the invalid attribute on the
vaadin-combo-box
doens't solve the problem as well, it looks like this value is not reflected in the innervaadin-text-field
.Browsers Affected
I think the other browsers have the same issue, however I was not able to test them
The text was updated successfully, but these errors were encountered: