New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on-change callback not working on version 4.2.6. #792
Comments
This can be reproduced in https://cdn.vaadin.com/vaadin-combo-box/4.2.6/demo/#combo-box-basic-demos by setting a change listener on any of the combo boxes. E.g. select one in inspector and run Actually this only seems to be a problem in the case when you select an item by clicking on the items in the dropdown. The change event is still triggered normally if you select an item via keyboard navigation or by typing in an exact match and then unfocusing or hitting Enter. Can confirm this is a regression in v4.2.6. If you try the same in https://cdn.vaadin.com/vaadin-combo-box/4.2.5/demo/#combo-box-basic-demos then the event is triggered normally also when you select the item by clicking on it. |
This regression was introduced by #785. It works fine on the previous commit before that. |
Adds a test for verifying if the regression described in #792 is fixed or not. This test is currently failing, but would pass if this change would be reverted https://github.com/vaadin/vaadin-combo-box/pull/785/files#diff-b73223a74b9a1b791eaba97e72452eb5 though reverting that would break 2 lazy loading tests.
Adds a test for verifying if the regression described in #792 is fixed or not. This test is currently failing, but would pass if this change would be reverted https://github.com/vaadin/vaadin-combo-box/pull/785/files#diff-b73223a74b9a1b791eaba97e72452eb5 though reverting that would break 2 lazy loading tests.
Adds a test for verifying if the regression described in #792 is fixed or not. This test is currently failing, but would pass if this change would be reverted https://github.com/vaadin/vaadin-combo-box/pull/785/files#diff-b73223a74b9a1b791eaba97e72452eb5 though reverting that would break 2 lazy loading tests.
This fix is now in |
The fix is now in v4.2.7. |
Description
I have a combo box with an
on-change
event handler. The event handler only gets called when I clear the selection, not changing the selection. It happens in version 4.2.6 when using in Polymer 2.The text was updated successfully, but these errors were encountered: