Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new mixin for data provider #708

Closed
tomivirkki opened this issue Aug 28, 2018 · 0 comments
Closed

Add a new mixin for data provider #708

tomivirkki opened this issue Aug 28, 2018 · 0 comments
Assignees

Comments

@tomivirkki
Copy link
Member

tomivirkki commented Aug 28, 2018

child of #657

https://github.com/vaadin/vaadin-combo-box/tree/data-provider-proto
(the proto might not be optimal starting point to build on)

  • add tests for the feature

  • create dataProvider, size and pageSize APIs

    • dataProvider should receive props and callback as arguments when the internal iron-list requires new content
      • props has page, pageSize
      • callback is invoked with requested set of items (or less) and optional size
    • size should reflect as full capacity of the iron-list
    • pageSize dicatates how many items the dataProvider is asked for per request
  • internally the dataProvidershould populate filteredItems

  • Throw an exception if dataProvider and items are used simultaneously

  • Toggle loading property while dataProvider is waiting for new items

No itemIdPath should be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants