Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable Combo box #663

Closed
7 tasks done
osamamaruf opened this issue May 29, 2018 · 4 comments
Closed
7 tasks done

Editable Combo box #663

osamamaruf opened this issue May 29, 2018 · 4 comments
Projects

Comments

@osamamaruf
Copy link

Description

Provide a mechanism/documentation to add new items to the vaadin-combo-box.

Expected outcome

Vaadin combo box should provide mechanism to add items e.g.

https://demo.vaadin.com/sampler/#ui/data-input/multiple-value/combo-box

Actual outcome

Cannot add new items.

Browsers Affected

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE 11
  • iOS Safari
  • Android Chrome
@osamamaruf
Copy link
Author

osamamaruf commented May 29, 2018

/**
* If true, the user can input a value that is not present in the items list.
* value property will be set to the input value in this case.
* Also, when value is set programmatically, the input value will be set
* to reflect that value.
*/
allowCustomValue: {
type: Boolean,
value: false
},
Found the above snippet in vaadin-combo-box-mixin.html. :)

In code do:
<vaadin-combo-box allow-custom-value ...

Can this be mentioned in the docs as well here.

@web-padawan
Copy link
Member

It is mentioned, actually. See the "Allow Custom Values" demo here. Is it clear enough for you, or maybe you suggest making a slightly more verbose description?

@osamamaruf
Copy link
Author

It would be better if its made more verbose. 'Custom Values' to me is a bit misleading. It would be good if 'editable' can also be use to describe it.

@jtomass jtomass added this to 📬  Inbox in vaadin-core Mar 29, 2019
@samiheikki
Copy link
Contributor

To me Custom Values sounds better than editable. Editable sounds like you could edit the combo-box items (add/update/remove them) where as custom value is used only for one custom value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
vaadin-core
  
📬  Inbox
Development

No branches or pull requests

4 participants