Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabindex support #401

Closed
Saulis opened this issue Feb 14, 2017 · 1 comment
Closed

Tabindex support #401

Saulis opened this issue Feb 14, 2017 · 1 comment
Assignees
@manolo
Labels
enhancement New feature or request
Milestone
3.0.0-alpha1

Comments

@Saulis
Copy link
Contributor

Saulis commented Feb 14, 2017

Description

When tabindex is set, tabbing into <vaadin-combo-box> doesn't focus the input.

Expected outcome

The input inside "second" <vaadin-combo-box> should be focused.

Actual outcome

<vaadin-combo-box> is focused.

Live Demo

https://jsfiddle.net/Saulis/b71f1cms/

Steps to reproduce

  1. Focus the first input
  2. Hit tab

Related with #349
@Saulis Saulis added the enhancement New feature or request label Feb 14, 2017
@Saulis
Copy link
Contributor Author

Saulis commented Feb 14, 2017

Here's my proposal how to fix it: https://jsfiddle.net/Saulis/8mj7xzfa/

@frami frami mentioned this issue Jun 14, 2017
Merged
manolo added a commit that referenced this issue Jul 25, 2017
@manolo
Implement tabindex. Fixes #401
32b08b4
manolo added a commit that referenced this issue Jul 25, 2017
@manolo
Implement tabindex. Fixes #401
f1ffa03
@manolo manolo self-assigned this Jul 25, 2017
limonte added a commit that referenced this issue Jul 26, 2017
@limonte
Merge pull request #488 from vaadin/feature/tabindex
10c1b7d 
Implement tabindex. Fixes #401
@manolo manolo added this to the 3.0.0-alpha1 milestone Jul 26, 2017
@manolo manolo closed this as completed Jul 26, 2017
@manolo manolo removed the in review label Jul 26, 2017
manolo added a commit that referenced this issue Jul 26, 2017
@manolo
Implement tabindex. Fixes #401
6c31c07
manolo added a commit that referenced this issue Jul 26, 2017
@manolo
Implement tabindex. Fixes #401
3e99c0a
manolo pushed a commit that referenced this issue Jul 26, 2017
@limonte @manolo
Merge pull request #488 from vaadin/feature/tabindex
1b926bf 
Implement tabindex. Fixes #401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manolo manolo

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.0-alpha1
Development

No branches or pull requests
2 participants
@manolo @Saulis