Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the torch_tensor_builder and torch_tensor_resolver to support bfloat16 #1885

Closed
dashanji opened this issue May 10, 2024 · 0 comments · Fixed by #1889
Closed

Implement the torch_tensor_builder and torch_tensor_resolver to support bfloat16 #1885

dashanji opened this issue May 10, 2024 · 0 comments · Fixed by #1889
Assignees
@dashanji
Labels
component:python Issues about vineyard's python SDK enhancement New feature or request

Comments

@dashanji
Copy link
Member

Describe your problem

Currently, the torch_tensor_builder and torch_tensor_resolver are cast to numpy builder and resolver directly, and bfloat16 is cast to float16 which caused the loss of accuracy.
@dashanji dashanji self-assigned this May 10, 2024
@dashanji dashanji added enhancement New feature or request component:python Issues about vineyard's python SDK labels May 10, 2024
@dashanji dashanji mentioned this issue May 13, 2024
Merged
sighingnow pushed a commit that referenced this issue May 21, 2024
@dashanji
Implement the torch builder and resolver to support bfloat16 (#1889)
a403b12 
Fixes #1885

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashanji dashanji

Labels
component:python Issues about vineyard's python SDK enhancement New feature or request
Projects
Vineyard Releases
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement the torch builder and resolver to support bfloat16 dashanji/v6d
1 participant
@dashanji