Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

之前做的一个GeoIP每周更新的Action,可以参考一下 #5

Open
Ricky-Hao opened this issue Dec 12, 2019 · 8 comments
Open

Comments

@Ricky-Hao
Copy link
Contributor

https://github.com/Ricky-Hao/geoip

@Ricky-Hao
Copy link
Contributor Author

如果需要固定Latest的Tag的话,可以参考这里
https://github.com/Ricky-Hao/SSTAP_Rules/blob/master/.github/workflows/sstap_rules.yml

@kslr
Copy link
Contributor

kslr commented Dec 12, 2019

挺好的,要发个pr吗

@Ricky-Hao
Copy link
Contributor Author

需要做成固定Label为Latest的那样么?如果要的话我去改一下

@kslr
Copy link
Contributor

kslr commented Dec 12, 2019

不需要,用时间就可以

@kslr
Copy link
Contributor

kslr commented Dec 18, 2019

遗憾的是这个仓库我无法设置,所以没有github token
https://github.com/v2ray/geoip/runs/353598527

我会在近期内合并到fly下的仓库里

@Loyalsoldier
Copy link
Contributor

不需要往仓库设置 Token,直接在 Workflow 里使用 ${{ secrets.GITHUB_TOKEN }} 就行了,Actions 会自动生成一个运行时 Token。已发 PR

@Ricky-Hao
Copy link
Contributor Author

666我才知道能这样(难怪不让设置以GITHUB_为开头的参数

@IceCodeNew
Copy link

IceCodeNew commented Jan 6, 2020

我之前没接触过 GitHub Action,不过看懂 .github/workflows/go.yml 要求干了什么操作还是没问题的。
我觉得现在的 Action 或许应该考虑加入“上次 Action 所用的数据库文件到这次 Action 之间是否发生过更新”的检查,或者直接改为每周运作一次。

官方网站上对 GeoLite2 数据库已经说的很明白了,每周才更新一次(具体是哪个时区的周二暂且不清楚),不过也足够说明现在每天 build 一个新的 geoip.dat 文件出来有点欠考虑了。

The GeoLite2 Country, City, and ASN databases are updated weekly, every Tuesday.

// 提了 PR #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants