Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsync.extraArgs does not work with strategy local #282

Open
adoerler opened this issue Mar 12, 2024 · 0 comments
Open

rsync.extraArgs does not work with strategy local #282

adoerler opened this issue Mar 12, 2024 · 0 comments

Comments

@adoerler
Copy link

Describe the bug
Due to missing LoadBalancer support on cluster side and unsupported NodeType service on pv-migrate side, I've to use strategy local.
Syncing iworks without problems, but it seems that one cannot use rsync.extraArgs in local szenario?

To Reproduce
Steps to reproduce the behavior:

  1. Run command pv-migrate migrate --helm-set rsync.extraArgs="--dry-run" --ignore-mounted --source-context k8s-source --source-namespace my-namespace --dest-context k8s-dest --dest-namespace my-namespace --strategies local pvc-test pvc-test
  2. Even using --dry-run all files get synced from source to target PV

This is just for demonstrating the problem. I'd like to use the extraArgs to sync only a subset of directories, like:
--helm-set rsync.extraArgs="--partial --inplace --include='/*/conf/lang/*' --exclude='*'"

Expected behavior
rsync.extraArgs should even work in strategy local.

Version

  • Source and destination Kubernetes versions: v1.12.10, v1.28.2
  • Source and destination container runtimes: docker://20.10.7, containerd://1.6.26
  • pv-migrate version and architecture: v1.7.1 - linux_x86_64
  • Installation method: binary download

Additional context

  • extraArgs have been added with this commit. Using local does not seem to use the job.yaml template at all.
  • Looking further into the code I would guess that the local strategy should also apply extraArgs if given.
    * rsync/cmd does not seem to have an option for passing additional args to rsync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant