Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Adding new podlabels can break kiam-agent daemonset #489

Open
harshal-shah opened this issue Jul 16, 2021 · 0 comments
Open

Adding new podlabels can break kiam-agent daemonset #489

harshal-shah opened this issue Jul 16, 2021 · 0 comments

Comments

@harshal-shah
Copy link
Contributor

We wanted to add new labels to kiam pods and we found that adding .Values.agent.podLabels updates the .spec.selector as well as .spec.template.metadata.labels which causes us to recreate the agent daemonset.

This happens due to these lines

In the server daemonset, this problem does not exist, as the server daemonset applies podLabels only on .spec.template.metadata.labels

I can send a PR to fix this, but it can potentially break users who are already using .Values.agent.podLabels as their daemonsets would need to be recreated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant