Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Out Remains for Multiple Years #237

Open
michaelhiiva opened this issue Jun 20, 2021 · 1 comment
Open

Sign Out Remains for Multiple Years #237

michaelhiiva opened this issue Jun 20, 2021 · 1 comment

Comments

@michaelhiiva
Copy link
Contributor

michaelhiiva commented Jun 20, 2021

Summary of the Bug

It seems unusual that we are checking the year of our user for Sign In, but not if they are the correct year on other years on the Sign Out link.

Steps to Reproduce the Behaviour

  1. Sign In with any account.
  2. Goto another year.

The Expected Behaviour

The Sign Out button should only be for the current year. Previous years should require separate Sign In.

Screenshots

2018

Screenshot from 2021-06-20 16-13-00

2020

Screenshot from 2021-06-20 16-13-09

2021

Screenshot from 2021-06-20 16-31-57

@neagle
Copy link
Collaborator

neagle commented Jun 21, 2021

Yeah, this is definitely a slightly funny aspect of the way the site works. I'm not sure it's a problem, though, especially since previous years are mainly kept around for historical reference.

To fix it, we could...

  1. Update the site so that one could be logged in to any number of years simultaneously -- that login status would be year-specific and not site-specific, and the site would really act like different years were fundamentally different sites. This is a bigger technical challenge than I know how to handle at the moment. :) (@jaredbeck?)

  2. Log a person out when they visit another year, which seems undesireable.

  3. ?

The mix of difficulty + low urgency from my perspective has always made me leave this on the pile.

@neagle neagle removed the bug label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants