Skip to content
This repository has been archived by the owner on Jul 25, 2019. It is now read-only.

Uservoice still not supporting bitcode ... #411

Open
nomadplanet opened this issue Mar 18, 2016 · 7 comments
Open

Uservoice still not supporting bitcode ... #411

nomadplanet opened this issue Mar 18, 2016 · 7 comments

Comments

@nomadplanet
Copy link

I could not build my app with bitcode enabled with the UV sdk 3.2.5

The error is

ld: bitcode bundle could not be generated because '[path]/libs/UserVoiceSDK-3.2.5/libUserVoice.a(UserVoice.o)' was built without full bitcode. All object files and libraries for bitcode must be generated from Xcode Archive or Install build for architecture armv7
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@austintaylor
Copy link
Contributor

I think this is just an issue with how the static library was built. I just updated the tarball for 3.2.7 to a version built with -fembed-bitcode set. Can you see if that solves your problem?

@nomadplanet
Copy link
Author

Unfortunately I still get the error :(

ld: bitcode bundle could not be generated because '/libs/UserVoiceSDK-3.2.7/libUserVoice.a(UserVoice.o)' was built without full bitcode. All object files and libraries for bitcode must be generated from Xcode Archive or Install build for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@nomadplanet
Copy link
Author

Not sure if that's related to the same issue but since 3.2.5 I get a bunch of warnings when linking (bitcode disabled) :

GenerateDSYMFile
[....]

while processing <project_path>/libs/UserVoiceSDK-3.2.7/libUserVoice.a(UserVoice.o):
warning: /var/folders/s_/m0fjy19n3_x5tnr4pfvx_z1c0000gp/C/com.apple.DeveloperTools/7.0-7A218/Xcode/SharedPrecompiledHeaders/UserVoice_Prefix-axbllcwdvmtdfsgaozoqlvgidayx/UserVoice_Prefix.pch.pch: No such file or directory
while processing <project_path>/libs/UserVoiceSDK-3.2.7/libUserVoice.a(UserVoice.o):
warning: /var/folders/s_/m0fjy19n3_x5tnr4pfvx_z1c0000gp/C/com.apple.DeveloperTools/7.0-7A218/Xcode/SharedPrecompiledHeaders/UserVoice_Prefix-axbllcwdvmtdfsgaozoqlvgidayx/UserVoice_Prefix.pch.pch: No object file for requested architecture
while processing <project_path>/libs/UserVoiceSDK-3.2.7/libUserVoice.a(UserVoice.o):
warning: Could not resolve external type c:objc(cs)NSBundle
while processing <project_path>/libs/UserVoiceSDK-3.2.7/libUserVoice.a(UserVoice.o):
warning: Could not resolve external type c:objc(cs)NSObject
while processing <project_path>/libs/UserVoiceSDK-3.2.7/libUserVoice.a(UserVoice.o):
warning: Could not resolve external type c:objc(cs)NSUndoManager
while processing <project_path>/libs/UserVoiceSDK-3.2.7/libUserVoice.a(UserVoice.o):
warning: Could not resolve external type c:objc(cs)NSObject
....
Showing first 200 warnings only

(Paths and output shorten)

@yuvalt
Copy link

yuvalt commented Jun 4, 2016

For other people who need help with this, this is how I went around this. Download the source code (git clone git@github.com:uservoice/uservoice-ios-sdk.git), modify the build.sh file with the below patches, run ./build.sh and use the generated zip file under dist/. The file libUserVoice.a would be double in size (roughly) and include bitcode.

-xcodebuild
+xcodebuild OTHER_CFLAGS="-fembed-bitcode"

-xcodebuild -sdk iphonesimulator
+xcodebuild OTHER_CFLAGS="-fembed-bitcode" -sdk iphonesimulator

@nomadplanet nomadplanet changed the title 3.2.5 not totally supporting bitcode ? Uservoice still not supporting bitcode ... Dec 14, 2016
@nomadplanet
Copy link
Author

9 months later, it's version 3.2.9 and you're still not providing binary releases with full bitcode support. How long will you take to change a flag ?

ld: bitcode bundle could not be generated because '[....]/UserVoiceSDK-3.2.9/libUserVoice.a(UserVoice.o)' was built without full bitcode. All object files and libraries for bitcode must be generated from Xcode Archive or Install build for architecture arm64

@madzack
Copy link

madzack commented Apr 8, 2017

When will the iOS library include bitcode support? If yuvalt hadn't posted the solution, I would not be using UserVoice any longer.

@andrewcl
Copy link
Contributor

andrewcl commented Apr 8, 2017

Let me look into seeing what's required to get Bitcode fully supported in the UserVoice SDK. I'll report back on this thread when I have a pull request in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants