Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor IME composing event behavior issue not fixed by #3267 #3285

Closed
Skywt2003 opened this issue Apr 25, 2024 · 1 comment
Closed

Editor IME composing event behavior issue not fixed by #3267 #3285

Skywt2003 opened this issue Apr 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Skywt2003
Copy link
Contributor

Describe the bug

#3267 并不能解决 macOS 上 Safari 的 #3263 这一问题。

经过测试,macOS 上 Safari 浏览器下 event.isComposing 的表现和 Chrome / Firefox 有所不同,上述情境发生时,Chrome / Firefox 中 isComposing 为 true,而 Safari 中为 false。如果只判断 isComposing,问题会仍然存在。

建议根据 MDN.文档,加上 event.keyCode 来判断(虽然 deprecated)。

(没有找到关于此问题的官方报告,只找到相关的一篇博客:https://fdream.net/blog/article/1288

#3267 does not address issue #3263 with Safari on macOS.

After testing, the performance of event.isComposing in Safari on macOS is different from that of Chrome/Firefox. When the above situation occurs, isComposing in Chrome/Firefox is true. In Safari, it is false. If you judge only isComposing, the problem still exists.

Suggestions according to the MDN Document, Add event.keyCode to determine (although deprecated).

(found no official report about this problem, only found a blog: https://fdream.net/blog/article/1288).

Steps to reproduce

Same as #3263

The version of Memos you're using

v0.21.0

Screenshots or additional context

No response

@Skywt2003 Skywt2003 added the bug Something isn't working label Apr 25, 2024
@boojack
Copy link
Collaborator

boojack commented Apr 27, 2024

Updated with 8bba7f7

@boojack boojack closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants