Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when uploaded images have the same name #3283

Closed
chenyuntc opened this issue Apr 25, 2024 · 3 comments
Closed

Errors when uploaded images have the same name #3283

chenyuntc opened this issue Apr 25, 2024 · 3 comments

Comments

@chenyuntc
Copy link
Sponsor

Describe the bug

I usually use ctrl+v to paste image to memos, which will save the file as image.jpg. I found that this will overwrite previous image.

Maybe memos need to save each file by uuid as name.

Steps to reproduce

  1. create a memo by uploading an image(e.g. image.png)
  2. create another memo by uploading another image, but with the same name
  3. Open previous memo, you'll find it's now showing wroing picture

The version of Memos you're using

0.21.0

Screenshots or additional context

No response

@chenyuntc chenyuntc added the bug Something isn't working label Apr 25, 2024
@MehadND
Copy link
Contributor

MehadND commented Apr 26, 2024

Maybe memos need to save each file by uuid as name.

I pretty sure it already does this check out the 0.19 folder in /migration/prod/0.19

Maybe see and let me know if I'm right.

@chenyuntc
Copy link
Sponsor Author

chenyuntc commented Apr 26, 2024

It still happen in my case. Maybe it's the issue rendering in markdown where the wrong path is passed

Note: you need to clear cache (e.g. open in incognito window) for this.
Besides, it's showing the wrong time for the attachment, where it says to be March 2024, which should be April

output

@chenyuntc
Copy link
Sponsor Author

This does not bother me now as I switch to S3 cloud storage for my resource storage, where I configure the storage path to be memos/{timestamp}_{filename}, which allocates a different name for each image.
But I guess it's still a bug need to be fixed for the database.

@boojack boojack removed the bug Something isn't working label May 2, 2024
@boojack boojack closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants