Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Allow filter dates #37

Closed
Aokromes opened this issue Aug 16, 2021 · 3 comments
Closed

[Feature request] Allow filter dates #37

Aokromes opened this issue Aug 16, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Aokromes
Copy link

how about allow search only forks updated the last 1 day / 1 week / 1 month / 1 year / custom?

@payne911
Copy link
Collaborator

payne911 commented Aug 16, 2021

That's a good idea. I would have to think about how I would integrate that into the UI.

Moreover, I think this could actually help with the restriction on the amount of calls because (iirc) that information is returned before I have to make an API call to obtain the before and after values.

However, keep in mind I'll unfortunately be busy with other things until October, though.

@payne911 payne911 added enhancement New feature or request website labels Aug 16, 2021
@payne911 payne911 changed the title [feature request] allow filter dates [Feature request] allow filter dates Aug 16, 2021
@payne911 payne911 changed the title [Feature request] allow filter dates [Feature request] Allow filter dates Aug 16, 2021
@takos22
Copy link

takos22 commented Nov 1, 2021

There could be a filter to every column, like if I only want forks that are no commits behind and at least 10 commits ahead.

@payne911
Copy link
Collaborator

payne911 commented Dec 6, 2022

There could be a filter to every column

I think this would be the best approach. It would ultimately unclog the "Settings" dialog which itself could be used for some more complex related things (for example, I have this idea about offering different scanning strategies to users, and maybe having the default be an automatic swap between strategies based on the amount of forks of the queried repo).

The right way to implement this would be to keep the entire result list in memory, and to only display a subset based on filtering preferences. The current implementation just throws away the data which doesn't meet the provided criterias, so it isn't flexible enough to support this kind of use-case.

I'd be stoked if someone wanted to work on this. :)

@payne911 payne911 removed the website label Jan 17, 2023
@payne911 payne911 added the help wanted Extra attention is needed label Jan 29, 2023
@payne911 payne911 pinned this issue Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants