Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bruno UI and CLI Reporters can expose secret variables #2186

Open
1 task done
marfranke opened this issue Apr 27, 2024 · 0 comments
Open
1 task done

Bruno UI and CLI Reporters can expose secret variables #2186

marfranke opened this issue Apr 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@marfranke
Copy link

I have checked the following:

  • I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add

The shown example is the Bearer Auth example from the testbench repo, but I've marked the bearer_auth_token as private. The UI still shows the token in the timelime tab. Same for the json export, that you can generate using the cli --format json option. This can expose your secrets if you are live-sharing your screen, share a screenshot or the exported report without manually hiding it. So I suggest, after the request is finished, check the whole output, including every header (request and response), response data, assertion/script output, etc..., for exact (or case-insensitive?) matches and replace them with something else, like a fixed number of asteriks or the variable name.

image

...
"headers": {
  "check": "again",
  "Authorization": "Bearer your_secret_token",
  "content-type": "application/json"
}
...

Mockups or Images of the feature

image

...
"headers": {
  "check": "again",
  "Authorization": "Bearer {{bearer_auth_token}}",
  "content-type": "application/json"
}
...
@marfranke marfranke added the enhancement New feature or request label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant