Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphcache-relayPagination): always set prev and next page in relaypagination #2538

Closed
wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link
Collaborator

Resolves #2521

Summary

We want our cursors to be defined in both directions as we are delivering a result so we can enable our user to paginate in both directions

Set of changes

  • add endCursor/startCursor and hasPrevious/hasNextPage to after/before paths

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

🦋 Changeset detected

Latest commit: 3675729

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock requested a review from kitten July 8, 2022 09:18
@JoviDeCroock JoviDeCroock deleted the pagination-pageinfo branch August 19, 2022 11:59
@BahaaZidan
Copy link

BahaaZidan commented Nov 3, 2022

@JoviDeCroock Can I ask why was this closed ? I'm running into this issue and would love for this to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relay pagination omits pageInfo fields
2 participants