Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to only print red URLs? #29

Open
maelle opened this issue Apr 10, 2020 · 7 comments
Open

option to only print red URLs? #29

maelle opened this issue Apr 10, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@maelle
Copy link

maelle commented Apr 10, 2020

Could there be an option to only print the URLs for which there was a failure? This way it'd be easier to go through them for a website that has many URLs?

@vsoch
Copy link
Collaborator

vsoch commented Apr 10, 2020

They are all printed in summary at the end, but yes we could definitely have a print fails only option!

@SuperKogito
Copy link
Member

I think a better option here is to set some sort of print levels, or better print style something --prints-style that can take value like all, fails-only, maybe success-only too?

@vsoch
Copy link
Collaborator

vsoch commented Apr 10, 2020

@SuperKogito I think this idea is spot on - after we review and merge #28 would you care to work on this for urlchecker-python? I think the variable might be something like --print-level to mirror the idea of logging levels.

@vsoch
Copy link
Collaborator

vsoch commented Apr 10, 2020

I'm going to transfer this issue to urlchecker-python, as it needs to be implemented there. As a follow up it will need to be added here.

@vsoch vsoch transferred this issue from urlstechie/urlchecker-action Apr 10, 2020
@vsoch
Copy link
Collaborator

vsoch commented Apr 10, 2020

This issue has been transferred to urlchecker-python - it will be followed up with update to urlchecker-action.

@vsoch vsoch added the enhancement New feature or request label Apr 10, 2020
@vsoch
Copy link
Collaborator

vsoch commented Apr 12, 2020

@SuperKogito you should be unblocked here now too!

@SuperKogito
Copy link
Member

SuperKogito commented Apr 13, 2020

yes I will make a PR of this today. Just wanted to ask, how about including a --print-level=none. The idea behind this, is that it can be useful, if we want to implement multiprocessing to provide a fast processing option, where the user will be only interested in the output file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants