Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker is dying for the request outside of the map #205

Open
ramovsky opened this issue Apr 27, 2018 · 2 comments
Open

Docker is dying for the request outside of the map #205

ramovsky opened this issue Apr 27, 2018 · 2 comments

Comments

@ramovsky
Copy link
Contributor

I've built a latest 5.17.2 version with the Berlin map following the Readme
But any request outside of the Berlin will kill the docker with

/usr/local/share/.config/yarn/global/node_modules/isochrone/node_modules/@turf/helpers/index.js:213
            throw new Error("Each LinearRing of a Polygon must have 4 or more Positions.");
            ^

Error: Each LinearRing of a Polygon must have 4 or more Positions.
    at Object.polygon (/usr/local/share/.config/yarn/global/node_modules/isochrone/node_modules/@turf/helpers/index.js:213:19)
    at makePolygon (/usr/local/share/.config/yarn/global/node_modules/isochrone/index.js:39:18)
    at Object.keys.reduce (/usr/local/share/.config/yarn/global/node_modules/isochrone/index.js:46:16)
    at Array.reduce (<anonymous>)
    at makePolygons (/usr/local/share/.config/yarn/global/node_modules/isochrone/index.js:43:33)
    at options.osrm.table (/usr/local/share/.config/yarn/global/node_modules/isochrone/index.js:104:26)

https://github.com/urbica/galton/blob/master/src/index.js#L37
And I was expecting 500 response (400 will more suite for that exact problem, but....)

@stepankuzmin
Copy link
Member

Yep, this makes sense. Will fix that with next release. Thanks, @ramovsky!

@mvaleev
Copy link

mvaleev commented Jul 16, 2018

Same error in v5.18.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants