Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fzf-marks complains if FZF_MARKS_FILE points at a readonly file #50

Open
peterhoeg opened this issue Mar 22, 2021 · 2 comments
Open

fzf-marks complains if FZF_MARKS_FILE points at a readonly file #50

peterhoeg opened this issue Mar 22, 2021 · 2 comments

Comments

@peterhoeg
Copy link

If for whatever reason that file is readonly, fzf-marks will throw a warning about not being able to do inplace editing. It still works as normal though.

@urbainvaes
Copy link
Owner

This is because the directories are sorted from the most recently to the least recently visited, in order to make it easier to jump to recently used marks. We could add an option to enable/disable this behaviour explicitly, which could default to 'disable' if the file is readonly and 'enable' otherwise. What do you think?

@peterhoeg
Copy link
Author

That's definitely an option.

Ideally the list of directories is separate from the ordering so that the it can be kept readonly while the dynamic ordering data is stored in a rw location.

urbainvaes added a commit that referenced this issue Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants