Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique()-ing records breaks es_search() as of data.table 1.12.0 #137

Closed
jameslamb opened this issue Jan 30, 2019 · 0 comments
Closed

unique()-ing records breaks es_search() as of data.table 1.12.0 #137

jameslamb opened this issue Jan 30, 2019 · 0 comments
Labels

Comments

@jameslamb
Copy link
Collaborator

Earlier today @fparages noted that uptasticsearch::es_search() was throwing an error like this:

Error in forderv(x, by = by, sort = FALSE, retGrp = TRUE) :
Column 2 of by= (2) is type 'list', not yet supported

We tracked this down to only occurring when the result had hits where at least one field was an array. In Felipe's case, this was occurring when he use sorting and every hit then came back with this in it:

"sort": [
    "all",
    "some_id"
]

After some investigation tonight, I discovered Rdatatable/data.table#3332. Basically running unique(someDT) when someDT contains any columns that are lists will throw an error as of data.table 1.12.0 (released two weeks ago).

@jameslamb jameslamb added the bug label Jan 30, 2019
jameslamb added a commit that referenced this issue Jan 30, 2019
changed strategy for dropping duplicates (fixes #137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant