Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Remove assetId as requirement and make grouping optional #27

Open
jayqi opened this issue Aug 14, 2019 · 1 comment
Open

Proposal: Remove assetId as requirement and make grouping optional #27

jayqi opened this issue Aug 14, 2019 · 1 comment
Labels
bug Something isn't working enhancement New feature or request question Further information is requested

Comments

@jayqi
Copy link
Contributor

jayqi commented Aug 14, 2019

Right now append_slope_features requires a column named "assetId" which it will use to group observations for the purpose of calculating stateful features. I believe this is unnecessarily opinioned about how users are using groundhog. I propose we remove this requirement, and instead include an optional parameter to specify a grouping column. This means that a user with observations for only one entity will not need to make a dummy assetId column.
@jameslamb jameslamb added bug Something isn't working enhancement New feature or request question Further information is requested labels Aug 14, 2019
@jameslamb
Copy link
Collaborator

I agree with this completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayqi @jameslamb