Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a .dockerignore #18

Open
jameslamb opened this issue Aug 9, 2019 · 2 comments
Open

Add a .dockerignore #18

jameslamb opened this issue Aug 9, 2019 · 2 comments
Assignees
@samwaterbury
Labels
ci good first issue Good for newcomers

Comments

@jameslamb
Copy link
Collaborator

We should have a .dockerignore file to control what ends up in the app container (https://codefresh.io/docker-tutorial/not-ignore-dockerignore/).

The initial contents of this file is left to whoever picks up this issue! At a minimum it should include .git/
@jameslamb jameslamb added good first issue Good for newcomers ci labels Aug 9, 2019
@samwaterbury
Copy link
Contributor

Working on this too now!

@jameslamb
Copy link
Collaborator Author

@samwaterbury I assigned this to you just so no one else takes it. I realized that there is already a .dockerignore (https://github.com/uptake/groundhog/blob/master/.dockerignore), but see if you can recommend any things that should be added!

At a minimum, I think we should ignore the clients (since this container is only for running the app).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samwaterbury samwaterbury

Labels
ci good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameslamb @samwaterbury