Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate display from logic #25

Open
wmertens opened this issue Jul 18, 2019 · 1 comment
Open

separate display from logic #25

wmertens opened this issue Jul 18, 2019 · 1 comment

Comments

@wmertens
Copy link

I like the approach here and I appreciate all the aria things, but I think the current styling approach is a bit heavy-handed.

How about separating the styling into the absolutely necessary for modals, and the optional for making it look nice? Then the necessary bits can be done with inline styles, which work everywhere, and the optional bits can be in a css file that the user has to include themselves.

An additional approach would be to allow passing components that replace the ones with optional styling. That way css-in-js can be used as well.

@King-Success
Copy link

I agree with this. It should allow for inline styling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants