Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

application.py contains checks that should be done in cli.py #339

Open
pirat89 opened this issue Nov 1, 2017 · 0 comments
Open

application.py contains checks that should be done in cli.py #339

pirat89 opened this issue Nov 1, 2017 · 0 comments
Labels

Comments

@pirat89
Copy link
Collaborator

pirat89 commented Nov 1, 2017

In case of another cleanup, would be nice to move all checks of used cli options combinations into the cli.py. E.g.:

    if self.conf.mode and self.conf.select_rules
        log_message(settings.options_not_allowed)
        return ReturnValues.MODE_SELECT_RULES

Maybe some checks are strewn inside other files. But it doesn't make sense to keep them anywhere outside of cli.py.

@pirat89 pirat89 added the cleanup label Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant